Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Not hydrating in iOS 10 #1963

Closed
tricki opened this issue Oct 18, 2019 · 4 comments
Closed

bug: Not hydrating in iOS 10 #1963

tricki opened this issue Oct 18, 2019 · 4 comments
Labels

Comments

@tricki
Copy link
Contributor

tricki commented Oct 18, 2019

Stencil version:

 @stencil/core@1.7.2

I'm submitting a:

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://stencil-worldwide.herokuapp.com/ or https://forum.ionicframework.com/

Current behavior:
No components get hydrated.

Expected behavior:
Components get hydrated.

Steps to reproduce:
Open app in Safari on iOS 10.

Other information:
After some digging I found that the nomodule script (app.js) is being downloaded, but not the type="module" script (p-********.js). app.js only runs to this line, which evaluates to false:

    // Safari 10 support type="module" but still download and executes the nomodule script
    if (!currentScript || !currentScript.hasAttribute('nomodule') || !('onbeforeload' in currentScript)) { 

Commit which seems to have introduced this bug: 35d61a4

@ionitron-bot ionitron-bot bot added the triage label Oct 18, 2019
@tricki
Copy link
Contributor Author

tricki commented Oct 18, 2019

Just found #1900 which describes the same bug in the comments. Feel free to close this issue if the discussion should take place there.

@dutscher
Copy link
Contributor

we decided to use the "loader" variant. we raised from 1.3.0 -> 1.7.0 and all our safari 10 user can't use the page now.

see: #1900 (comment)

cheers

@dutscher
Copy link
Contributor

btw safari 10.0 on ios has a old webkit.performance api https://developer.mozilla.org/de/docs/Web/Web_Components

and breaks silently at performance.mark(), performance.measure & performance.getEntriesByName

to get rid of use stencil build --no-profile

@adamdbradley
Copy link
Contributor

Thanks for the fix!

@ionic-team ionic-team locked as resolved and limited conversation to collaborators Dec 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants