Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance profile API in Safari 10.0 iOS dont have methods 'mark', 'measure' and 'getEntriesByName' #2080

Closed
dutscher opened this issue Dec 17, 2019 · 1 comment
Labels

Comments

@dutscher
Copy link
Contributor

dutscher commented Dec 17, 2019

Stencil version:

 @stencil/core@1.7.0

I'm submitting a:
[x] bug report
[ ] feature request
[ ] support request

Current behavior:
Your Browser support says Safari 10.1+ https://stenciljs.com/docs/browser-support.
When we look onto the Mac Safari 10 https://en.wikipedia.org/wiki/Safari_version_history#Safari_10, we can see in 10.1 is new "New web technology additions and improvements".
BUT!
We talk about iOS. https://en.wikipedia.org/wiki/Safari_version_history#Safari_10_2
It is a 10.0 minor.

I found, that in 1.7.0 the profiling was add or optimized:

runtime: add performance profiling (f5817a0)

The API on iOS 10.0 for profiling exists, but dont has the methods mark, measure and getEntriesByName.
image
A workarround that all webcomponents are hydrating is to use stencil build --no-profile, which is nowhere documented.

Why is BUILD.profile default true and not false?
Is there a documentation?

Expected behavior:
iOS 10 works out of the box as the Browser Support says

Steps to reproduce:
See other issues:
#1900
#1963
#1403

Related code:
https://github.com/ionic-team/stencil/blob/master/src/runtime/profile.ts#L9
https://github.com/ionic-team/stencil/blob/master/src/runtime/profile.ts#L15
https://github.com/ionic-team/stencil/blob/master/src/runtime/profile.ts#L27

Other information:
Here is a Pullrequest #2081

cheers

@ionitron-bot ionitron-bot bot added the triage label Dec 17, 2019
@dutscher dutscher changed the title performance profiling API in Safari 10.0 on iOS Performance profile API in Safari 10.0 iOS dont have methods 'mark', 'measure' and 'getEntriesByName' Dec 17, 2019
@manucorporat
Copy link
Contributor

Fixed by #2081! Thanks a lot for the PR!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants