bug: cli args parsing fails

[jasperbosch]

Prerequisites

• I have read the Contributing Guidelines.
• I agree to follow the Code of Conduct.
• I have searched for existing issues that already report this problem, without success.

Stencil Version

2.17.x

Current Behavior

When executing stencil test --spec --e2e --json --outputFile=output.json the outputFile-argument is badly parsed. It will result in jest --spec --e2e --json --outputFile=output.json output.json, wich will result in not executing jest.

However executing stencil test --spec --e2e --json --output-file output.json will succeed.

Cause is in the parse-flags.ts file:

args.forEach((arg, i) => {
    if (arg.startsWith(`--${dashCaseName}=`) || arg.startsWith(`--${configCaseName}=`)) {
      value = getEqualsValue(arg);
      matchingArg = arg;
    } else if (arg === `--${dashCaseName}` || arg === `--${configCaseName}`) {
      value = args[i + 1];
      matchingArg = arg;
    } else if (alias) {
      if (arg.startsWith(`-${alias}=`)) {
        value = getEqualsValue(arg);
        matchingArg = arg;
      } else if (arg === `-${alias}`) {
        value = args[i + 1];
        matchingArg = arg;
      }
    }
  });

matchingArg (on line 4) should only contain --outputFile= but now contains --outputFile=output.json

Expected Behavior

Expect to execute jest with: jest --spec --e2e --json --outputFile=output.json

Steps to Reproduce

execute stencil test --spec --e2e --json --outputFile=output.json

Code Reproduction URL

Additional Information

No response

[alicewriteswrongs]

hey @jasperbosch, thanks for filing this issue and for doing some code spelunking! You're right that this is an issue. I was just in this code recently so I'll fix it today.

[alicewriteswrongs]

Thanks for reporting this! Just to update you, there's a bugfix PR up here: #3483 which just merged into main.

If you want to test it out to make sure it fixes your issue you could

• clone the repo locally
• check out the branch
• do npm install, npm run build and npm pack
• try installing the resulting .tgz file in our project by doing npm install ./path/to/stencil.tgz

If you'd rather wait for a pre-release or release build to try that out no worries :)

[rwaskiewicz]

The fix for this issue has been officially released as a part of Stencil v2.17.2. As a result, I'm going to close this issue and mark it as completed. If the bug re-appears, please feel free to open a new issue!