-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mock-doc): provide a local name #5480
Conversation
STENCIL-1126
|
Path | Location | Error | Message |
---|---|---|---|
src/mock-doc/document.ts | (52, 16) | TS2416 | |
src/mock-doc/document.ts | (60, 5) | TS2322 | |
src/mock-doc/document.ts | (132, 40) | TS2345 | |
src/mock-doc/document.ts | (143, 42) | TS2345 | |
src/mock-doc/document.ts | (221, 27) | TS2345 | |
src/mock-doc/document.ts | (225, 30) | TS2345 | |
src/mock-doc/document.ts | (246, 32) | TS2322 | |
src/mock-doc/document.ts | (251, 30) | TS2345 | |
src/mock-doc/document.ts | (312, 3) | TS2322 | |
src/mock-doc/event.ts | (57, 28) | TS2352 | |
src/mock-doc/node.ts | (485, 20) | TS2345 | |
src/mock-doc/node.ts | (491, 20) | TS2345 | |
src/mock-doc/node.ts | (500, 22) | TS2345 | |
src/mock-doc/node.ts | (512, 22) | TS2345 | |
src/mock-doc/node.ts | (520, 20) | TS2345 | |
src/mock-doc/node.ts | (526, 20) | TS2345 |
reports and statistics
Our most error-prone files
Path | Error Count |
---|---|
src/dev-server/index.ts | 37 |
src/dev-server/server-process.ts | 32 |
src/compiler/prerender/prerender-main.ts | 22 |
src/testing/puppeteer/puppeteer-element.ts | 22 |
src/runtime/client-hydrate.ts | 20 |
src/screenshot/connector-base.ts | 19 |
src/runtime/vdom/vdom-render.ts | 17 |
src/dev-server/request-handler.ts | 15 |
src/compiler/prerender/prerender-optimize.ts | 14 |
src/compiler/sys/stencil-sys.ts | 14 |
src/compiler/transpile/transpile-module.ts | 14 |
src/sys/node/node-sys.ts | 14 |
src/compiler/prerender/prerender-queue.ts | 13 |
src/compiler/sys/in-memory-fs.ts | 13 |
src/runtime/connected-callback.ts | 13 |
src/runtime/set-value.ts | 13 |
src/compiler/output-targets/output-www.ts | 12 |
src/compiler/transformers/test/parse-vdom.spec.ts | 12 |
src/compiler/transformers/transform-utils.ts | 12 |
src/mock-doc/test/attribute.spec.ts | 12 |
Our most common errors
Typescript Error Code | Count |
---|---|
TS2322 | 361 |
TS2345 | 351 |
TS18048 | 207 |
TS18047 | 82 |
TS2722 | 37 |
TS2532 | 24 |
TS2531 | 21 |
TS2454 | 14 |
TS2790 | 11 |
TS2352 | 11 |
TS2769 | 8 |
TS2538 | 8 |
TS2416 | 7 |
TS2493 | 3 |
TS18046 | 2 |
TS2684 | 1 |
TS2430 | 1 |
Unused exports report
There are 14 unused exports on this PR. That's the same number of errors on main, so at least we're not creating new ones!
Unused exports
File | Line | Identifier |
---|---|---|
src/runtime/bootstrap-lazy.ts | 21 | setNonce |
src/screenshot/screenshot-fs.ts | 18 | readScreenshotData |
src/testing/testing-utils.ts | 198 | withSilentWarn |
src/utils/index.ts | 145 | CUSTOM |
src/utils/index.ts | 269 | normalize |
src/utils/index.ts | 7 | escapeRegExpSpecialCharacters |
src/compiler/app-core/app-data.ts | 25 | BUILD |
src/compiler/app-core/app-data.ts | 115 | Env |
src/compiler/app-core/app-data.ts | 117 | NAMESPACE |
src/compiler/fs-watch/fs-watch-rebuild.ts | 123 | updateCacheFromRebuild |
src/compiler/types/validate-primary-package-output-target.ts | 61 | satisfies |
src/compiler/types/validate-primary-package-output-target.ts | 61 | Record |
src/testing/puppeteer/puppeteer-declarations.ts | 485 | WaitForEventOptions |
src/compiler/sys/fetch/write-fetch-success.ts | 7 | writeFetchSuccessSync |
PR built and packed!Download the tarball here: https://github.com/ionic-team/stencil/actions/runs/8288219844/artifacts/1327741923 If your browser saves files to
|
This reverts commit 2f67b35.
What is the current behavior?
Currently MockDoc doesn't provide a
localName
property for elements.GitHub Issue Number: #5342
What is the new behavior?
Adding that property.
Documentation
n/a
Does this introduce a breaking change?
Testing
Added some unit tests. Let me know if I should extend these.
Other information
n/a