Revert "fix(custom-elements): hydrate on client side (#5317)" #6111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d809658.
christian-bromann
force-pushed
the
cb/hydrate-fix
branch
from
805f53a to
9c3fcfb
Compare
christian-bromann
added a commit
that referenced
this pull request
Feb 4, 2025
christian-bromann
added a commit
that referenced
this pull request
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d809658.
What is the current behavior?
When compiling for
dist-custom-element, there is no need to include the lazy load functionality into the runtime. In fact it causes issues with Next.js and Turbopack when using SSR:The original PR (see commit above) fixed a rendering issue that occured with Stencil v4.7. However the origin of the problem is not apparent anymore as we have moved to Declarative Shadow DOM for SSR rendering.
What is the new behavior?
Don't include the lazy load components as part of the
dist-custom-elementruntime.Documentation
Does this introduce a breaking change?
Testing
n/a
Other information
n/a