Don't generate params for explicit getters/setters as they are flagge…

…d invalid by the compiler
ionide · Apr 20, 2024 · 5c48c55 · 5c48c55
1 parent 9c04d1e
commit 5c48c55
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/FsAutoComplete.Core/Commands.fs b/src/FsAutoComplete.Core/Commands.fs
@@ -1397,15 +1397,15 @@ type Commands() =
                                     headPat = SynPat.LongIdent(longDotId = longDotId)))) when
                                 rangeContainsPos longDotId.Range pos && xmlDoc.IsEmpty
                                 ->
-                                Some(false, tryGetFirstAttributeLine attributes)
+                                Some(true, tryGetFirstAttributeLine attributes)
                               | SynMemberDefn.GetSetMember(
                                   memberDefnForGet = Some(SynBinding(
                                     attributes = attributes
                                     xmlDoc = xmlDoc
                                     headPat = SynPat.LongIdent(longDotId = longDotId)))) when
                                 rangeContainsPos longDotId.Range pos && xmlDoc.IsEmpty
                                 ->
-                                Some(false, tryGetFirstAttributeLine attributes)
+                                Some(true, tryGetFirstAttributeLine attributes)
                               | _ -> None)
                           | _ -> None)
                       | _ -> None)

diff --git a/test/FsAutoComplete.Tests.Lsp/CodeFixTests/Tests.fs b/test/FsAutoComplete.Tests.Lsp/CodeFixTests/Tests.fs
@@ -1752,7 +1752,6 @@ let private generateXmlDocumentationTests state =
         type MyClass() =
           let mutable someField = ""
           /// <summary></summary>
-          /// <param name="x"></param>
           /// <returns></returns>
           member _.Name
             with get () = "foo"
@@ -1794,7 +1793,6 @@ let private generateXmlDocumentationTests state =
         type MyClass() =
           let mutable someField = ""
           /// <summary></summary>
-          /// <param name="x"></param>
           /// <returns></returns>
           member _.Name
             with set (x: string) = someField <- x