Fix debugger regression (#1230)

* add changelogs for next version * make Project Output the executable/loadable assembly, not the reference assembly again
ionide · Feb 13, 2024 · df78a3d · df78a3d
1 parent 09f5daa
commit df78a3d
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,13 @@
 
 * [Analyzers: Update analyzers support to 0.24.0](https://github.com/fsharp/FsAutoComplete/pull/1229) (thanks @nojaf)
 
+
+## [0.70.0] - 2024-02-06
+
+### Changed
+
+* [Update Ionide.ProjInfo and enable support for Reference Assemblies where they exist](https://github.com/fsharp/FsAutoComplete/pull/1228)
+
 ## [0.69.0] - 2024-01-14
 
 ### Added

diff --git a/src/FsAutoComplete/CommandResponse.fs b/src/FsAutoComplete/CommandResponse.fs
@@ -146,17 +146,27 @@ module CommandResponse =
       Version: string
       FullPath: string }
 
+  /// a structure containing the data needed to render project trees for a solution explorer
   type ProjectResponse =
-    { Project: ProjectFilePath
+    {
+      /// the fully qualified path to the project file
+      Project: ProjectFilePath
+      /// the list of fully-qualified paths of the files in the project
       Files: List<SourceFilePath>
+      /// the fully-qualified path to the primary output (executable, library, etc.) of the project.
+      /// note that this is _not_ a reference assembly
       Output: string
       ProjectReferences: List<ProjectReference>
       PackageReferences: List<PackageReference>
       References: List<ProjectFilePath>
       OutputType: ProjectOutputType
+      /// a useful subset of project file properties for this permutation of the project
       Info: ProjectResponseInfoDotnetSdk
+      /// the list of items in the project, such as compile items, content items, etc. this
+      /// should be a superset of data like the Files, Project/Package References, etc
       Items: List<ProjectResponseItem>
-      AdditionalInfo: Map<string, string> }
+      AdditionalInfo: Map<string, string>
+    }
 
   and ProjectOutputType =
     | Library

diff --git a/src/FsAutoComplete/LspServers/AdaptiveServerState.fs b/src/FsAutoComplete/LspServers/AdaptiveServerState.fs
@@ -852,7 +852,7 @@ type AdaptiveState(lspClient: FSharpLspClient, sourceTextFactory: ISourceTextFac
           let ws =
             { ProjectFileName = projectFileName
               ProjectFiles = responseFiles
-              OutFileOpt = Option.ofObj projectOption.ResolvedTargetPath
+              OutFileOpt = Option.ofObj projectOption.TargetPath
               References = references
               Extra = projectOption
               ProjectItems = projViewerItemsNormalized.Items