Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements to generated XML Doc codefixes #1104

Closed
baronfel opened this issue Apr 15, 2023 · 1 comment · Fixed by #1106
Closed

Enhancements to generated XML Doc codefixes #1104

baronfel opened this issue Apr 15, 2023 · 1 comment · Fixed by #1106
Assignees
@dawedawe
Labels
help wanted type:codefix Work that adds or updates a codefix in the product

Comments

@baronfel
Copy link
Contributor

As mentioned by @dawedawe in #1094:

There are two things the command could be improved on:

  • Don't add xml doc lines if there are already some doc lines present.
  • Work on all possible AST elements, not just the ones for which we get a result from TryGetSignatureData.

These both sound like fine enhancements for anyone that wants to take a look.
@baronfel baronfel added help wanted type:codefix Work that adds or updates a codefix in the product labels Apr 15, 2023
@dawedawe
Copy link
Contributor

I'll take care of this. Maybe in one of the next amplify sessions.

@dawedawe dawedawe mentioned this issue Apr 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dawedawe dawedawe

Labels
help wanted type:codefix Work that adds or updates a codefix in the product
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve xml doc command dawedawe/FsAutoComplete
2 participants
@baronfel @dawedawe