Improve xml doc command #1106
Merged
Improve xml doc command #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't add xml doc lines if there are already some doc lines present. - Work on all possible AST elements, not just the ones for which we get a result from TryGetSignatureData. Adjust tests accordingly
|
This LGTM - @TheAngryByrd any reason not to merge? We can do a release this weekend. |
TheAngryByrd
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cleaned up result of todays Amplify F# session. Fixes #1104
Adjust tests accordingly
WHAT
🤖 Generated by Copilot at ff2ee3d
This pull request improves the code fix feature for generating XML documentation for F# elements, by adding more cases, simplifying the code, and updating the tests. It affects the files
src/FsAutoComplete.Core/Commands.fs,src/FsAutoComplete/CodeFixes/GenerateXmlDocumentation.fs, andtest/FsAutoComplete.Tests.Lsp/CodeFixTests/Tests.fs.🤖 Generated by Copilot at ff2ee3d
📝🔧🧪
WHY
HOW
🤖 Generated by Copilot at ff2ee3d
FsAutoComplete.CodeFix.GenerateXmlDocumentationmodule fromsrc/FsAutoComplete/CodeFixes/GenerateXmlDocumentation.fstosrc/FsAutoComplete.Core/Commands.fswhere the rest of the code fix features are defined (link)