Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up FSharp.CompilerBinding agent API #17

Closed
rneatherway opened this issue Jun 9, 2015 · 2 comments
Closed

Clean up FSharp.CompilerBinding agent API #17

rneatherway opened this issue Jun 9, 2015 · 2 comments

Comments

@rneatherway
Copy link
Contributor

From @rneatherway on October 22, 2014 15:58

Comment in FSharp.AutoComplete/Program.fs:

// TODO: Clean up the API these options are being generated to call
//
// That API is in FSharp.CompilerBinding.LanguageService.
// 1. It expects a Target Framework, but only for FSI as
// FCS is rumoured not to return references including FSharp.Core
// and it uses the framework to guess where it is.
// We will just use 4.5.
// 2. The CompileFiles just get added to the options, so we will do that
// here and then pass in an empty array of CompileFiles.

Any changes will also affect monodevelop binding.

Copied from original issue: fsprojects/zarchive-fsharpbinding#772
@rneatherway
Copy link
Contributor Author

From @7sharp9 on December 15, 2014 14:6

Is this now complete then?

@rneatherway
Copy link
Contributor Author

From @7sharp9 on April 29, 2015 15:51

I removed the XS label as this is no longer an issue there as its "evolving"

@rneatherway rneatherway mentioned this issue Jun 9, 2015
Closed
rneatherway added a commit to rneatherway/FsAutoComplete that referenced this issue Jul 27, 2015
@rneatherway
Large refactor of processing structure
1586d8d 
* FSharp.CompilerBinding removed, and used parts absorbed. Fixes ionide#17.
* ScriptCheckerOptions fetched with no timeout, and also stores them.
  Fixes ionide#18, ionide#28.
* If a .fs file is not in a loaded project, produce an incomplete
  typecheck environment for it to give basic results.
* Update helptext command to return { Name = ""; Text = "" }. Fixes ionide#35.
* Update parsing of project options to include ProjectReferences. Fixes ionide#39.
* Separate parsing of commands, main command loop, and formatting of
  response message into separate modules.
@rneatherway rneatherway mentioned this issue Jul 27, 2015
Merged
rneatherway added a commit to rneatherway/FsAutoComplete that referenced this issue Jul 27, 2015
@rneatherway
Large refactor of processing structure
99d6091 
Backwards-incompatible changes:

* Update helptext command to return { Name = ""; Text = "" }. Fixes ionide#35.
* `project` command response now has 'null' for OutputFile and
  TargetFramework if a value cannot be determined.

Other changes:

* FSharp.CompilerBinding removed, and used parts absorbed. Fixes ionide#17.
* ScriptCheckerOptions fetched with no timeout, and also stores them.
  Fixes ionide#18, ionide#28.
* If a .fs file is not in a loaded project, produce an incomplete
  typecheck environment for it to give basic results.
* Update parsing of project options to include ProjectReferences. Fixes ionide#39.
* Separate parsing of commands, main command loop, and formatting of
  response message into separate modules.
vasily-kirichenko added a commit to vasily-kirichenko/FsAutoComplete that referenced this issue Oct 21, 2016
@vasily-kirichenko @Krzysztof-Cieslak
fixed: Suave dies if handlers raise exceptions (ionide#17)
79cb5ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rneatherway