Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codefix for redundant attribute suffix. #1132

Merged
merged 1 commit into from
Jul 9, 2023

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Jul 9, 2023

RedundantAttributeSuffix

WHAT

🤖 Generated by Copilot at e3f0fd7

This pull request adds a new code fix for removing redundant "Attribute" suffixes from F# attribute applications. The code fix is implemented in the RemoveRedundantAttributeSuffix module and registered with both the AdaptiveFSharpLspServer and the FSharpLspServer types. The code fix is also tested in the test/FsAutoComplete.Tests.Lsp/CodeFixTests/Tests.fs file.

🤖 Generated by Copilot at e3f0fd7

Attribute suffix
Trimmed by a code fixer
Autumn leaves falling

🛠️📝🧪

WHY

HOW

🤖 Generated by Copilot at e3f0fd7

  • Add a new code fix for removing redundant attribute suffixes (link)
  • Enable the code fix for both language server implementations (link, link)
  • Add test cases for the code fix (link, link)

@TheAngryByrd TheAngryByrd merged commit ba90409 into ionide:main Jul 9, 2023
@TheAngryByrd
Copy link
Member

Awesome, I've found myself wanting this recently. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants