fix and improves l10n #1181
Merged
fix and improves l10n #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: codefix ReplaceWithSuggestion and ResolveNamespace can now deal with localized compiler texts improves: now can load localized xml documents
TheAngryByrd
approved these changes
Oct 29, 2023
There was a problem hiding this comment.
This is a another good step in the right direction, thanks!
@baronfel anything you'd like to add?
|
IMO we can take this for now - but I think the proper fix would be for compiler changes to dump the relevant data into the diagnostic extra data, like some folks have started doing recently. |
|
@Tangent-90 thank you for this contribution! |
1eyewonder
pushed a commit
to 1eyewonder/FsAutoComplete
that referenced
this pull request
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 26bce28
This pull request adds support for localized tooltips and code fixes for F# keywords, operators, errors, and warnings. It introduces new helper functions and modules to find and load localized XML files and match diagnostic messages. It modifies existing code fix modules to use the new functions and handle different message formats. It affects the files
TipFormatter.fs,ResolveNamespace.fs,CodeFixes.fs,CodeFixes.fsi, andReplaceWithSuggestion.fs.🤖 Generated by Copilot at 26bce28
🌐🔧💡
WHY
HOW
🤖 Generated by Copilot at 26bce28