Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show script option project diagnostics #1248

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

TheAngryByrd
Copy link
Member

Makes sure to pass along script file project option diagnostics.

image

Should give additional info for people having issues with the restore functionality in fsx scripts.

@TheAngryByrd TheAngryByrd requested a review from baronfel March 15, 2024 16:10
Copy link
Contributor

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glorious. Wonderful. Amazing.

@TheAngryByrd
Copy link
Member Author

TheAngryByrd commented Mar 15, 2024

Glorious. Wonderful. Amazing.

Tests are failing because we're only waiting for first error messages being sent. Which we're sending new diagnostics now.

Push diagnostics strike again!

@TheAngryByrd TheAngryByrd merged commit 6bdbbaa into ionide:main Mar 15, 2024
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants