Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binding to signature file code fix. #1249

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Mar 18, 2024

add_bniding_to_signature

When it comes to signature files, this one is probably my wet dream.

@baronfel
Copy link
Contributor

DAAAAAYUMMMM

@nojaf nojaf marked this pull request as ready for review March 19, 2024 08:13
@nojaf
Copy link
Contributor Author

nojaf commented Mar 19, 2024

This is a decent start for an initial version. However, there are significant limitations due to a lack of smart features:

  • It doesn't check if a type used is missing from the signature file; such types need to be included as well.
  • It simply appends the item at the end without employing a smarter approach.

Improving these aspects would greatly enhance user experience, but unfortunately, my time to work on this is restricted.

@TheAngryByrd TheAngryByrd merged commit e505c1f into ionide:nightly Mar 19, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants