Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In the Tooltip markdown, render generic type names with multiple segments correctly #1298

Merged
merged 2 commits into from
May 20, 2024
Merged

In the Tooltip markdown, render generic type names with multiple segments correctly #1298

merged 2 commits into from
May 20, 2024

Conversation

dawedawe
Copy link
Contributor

@dawedawe dawedawe commented May 19, 2024 •
edited
Loading

This tries to fix ionide/ionide-vscode-fsharp#1987
before:
Screenshot 2024-05-19 224858
after:
Screenshot 2024-05-19 225108

TheAngryByrd
TheAngryByrd approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheAngryByrd TheAngryByrd merged commit 592ed71 into ionide:main May 20, 2024
25 of 26 checks passed
@dawedawe dawedawe deleted the fix_generic_md branch May 20, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheAngryByrd TheAngryByrd TheAngryByrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code formatting for generic parameters located under a module is not correct
2 participants
@dawedawe @TheAngryByrd