Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sdk 2.0 support #166

Merged
merged 4 commits into from
Jun 10, 2017
Merged

add sdk 2.0 support #166

merged 4 commits into from
Jun 10, 2017

Conversation

enricosada
Copy link
Contributor

@enricosada enricosada commented Jun 10, 2017 •
edited
Loading

fix #165

todo:

  • support sdk 2.0
  • test on win
  • test on non-win

@enricosada
sdk 2.0 use path relative to projectFile for Compile items
9682dae 
So if a path is not absolute, then mean is relative to fsproj directory
@enricosada
add test
84a2f7c
@enricosada enricosada mentioned this pull request Jun 10, 2017
Closed
2 tasks
@enricosada
Copy link
Contributor Author

opening #167 to check travis failure

@enricosada
Copy link
Contributor Author

merging because travis failure is unrelated.

@rneatherway i added a test similar to the one for .net core sdk 1.0, and this automatically download the sdk 2.0
The change itself to support sdk 2.0 is minimal (just make compile files path absolute), and should not affect 1.0 because there path are already absolute

@enricosada enricosada merged commit 6de0fdb into ionide:master Jun 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support new new sdk (RFC FS-1032)
1 participant
@enricosada