Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove text mode #40

Merged
merged 7 commits into from
Jul 12, 2015
Merged

Remove text mode #40

merged 7 commits into from
Jul 12, 2015

Conversation

rneatherway
Copy link
Contributor

Also removes the 'help' command, moving it to a command line option --commands
Also canonicalise Kind field as lowercase, which affects INFO and ERROR, now info and error

@rojepp
Copy link
Contributor

rojepp commented Jul 12, 2015

LGTM, FWIW.
The readme should be updated as well?

@rneatherway
Copy link
Contributor Author

Thanks for taking a look, I've updated the READMEs. The AppVeyor test failed for a reason I haven't seen before, I think I'll have to double check running them on Windows.

Always use log timeouts in windows tests
@rneatherway
Copy link
Contributor Author

Windows tests pass locally, it's failing on AppVeyor due to an exception getting script checker options: #18, #28

rneatherway added a commit that referenced this pull request Jul 12, 2015
@rneatherway rneatherway merged commit 2b09f6b into ionide:master Jul 12, 2015
@rneatherway rneatherway deleted the remove-text-mode branch July 12, 2015 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants