Add support for gitpod.io for this repo #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
reviewed
May 8, 2021
Comment on lines
+1
to
+2
| image: | ||
| file: .devcontainer/Dockerfile |
There was a problem hiding this comment.
This can also be image: gitpod/workspace-dotnet; they build that workspace by running the dotnet-install script for the latest SDK so it's always up to date.
There was a problem hiding this comment.
that's a good idea! however it would mean that we wouldn't be in-sync all the time with the global.json in this repo (which we also keep up to date with the github actions sdk version), so I'm inclined to keep it pinned like I have it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a gitpod configuration file and some updates to the shared dockerfile so that we have a good experience out of the box.