use mailbox processors per-file to serialize diagnostics pushes #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing I have noticed here is that if the MBP errors, we'll start a new agent for that file, but we don't currently have a way of extracting the state from the already-running agent. We can't simply use a new message with a reply for that case, though, because the agent will be in an error state and (I believe) not responding to new messages. |
|
I'd like @Krzysztof-Cieslak's thought on this approach overall, but I'm pretty happy with it! |
baronfel
force-pushed
the
diagnostics-clobbering
branch
from
6d29679 to
a51104e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now each publish of diagnostics for a file is fired off via Async.Start into the void. This can result in ordering issues with the state of each files' diagnostics collection.
This PR serializes publishing of diagnostics per-file by using a mailboxprocessor as a synchronization agent per-file, with error logging and restarts. The state of the file is maintained in a map that's returned recursively, and this way each individual publish action for a file is well-ordered with respect to that file.