Use Uri instead of FileName for several fsharp/ requests
#949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Ionide: used for Info Panel
Change `HighlightingRequest`, `FSharpLiterateRequest` to use Uri too
* But neither of these two is actually used
Note: This commit results in changed API:
* Prev: `{ FileName: string }`
* Now: `{ TextDocument: TextDocumentIdentifier }`
-> Clients must be adjusted
|
Ideally I'd like to see tests over areas that change (just as part of a process of greening up the codebase overall over time), but I've tested these manually and the scope of the changes overall are minor. Personally I'd also like to remove the entire PlainNotification type over time, which requires the kind of cross-repo synchronization that you had to do for this effort, but that's a later effort. Maybe after #945 :) Thank you again for your attention to detail here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ionide quite a lot of commands don't work in untitled documents.
Reason: FileName instead of Uri is used.
Additional to changes here in FSAC, clients must make some adjustments too.
For Ionide these are in ionide/ionide-vscode-fsharp#1717
Changes:
fsharp/FileParsed: returns URI instead of FileName. No type change (isPlainNotification), but content is now URIFSharpPipelineHintRequest,HighlightingRequest,FSharpLiterateRequestuse nowTextDocumentIdentifier:{ FileName: string }{ TextDocument: TextDocumentIdentifier }Note: This results in changed API
-> as mentioned above: Clients must be adjusted
Additional Fix:
fsharp/f1Help&fsharp/documentation(used in Info Panel)