Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types: Do not use Obsolete attribute to annotate deprecated types in LSP #63

Merged
merged 1 commit into from
May 7, 2024

Conversation

razzmatazz
Copy link
Contributor

Language servers may still need/want to support deprecated types for older clients which results in unnecessary obsoletion warnings from the compiler.

…pes in LSP

Language servers may still need/want to support deprecated types for older clients which results in unnecessary
obsoletion warnings from the compiler.
@razzmatazz razzmatazz changed the title src/Types.fs: Do not use Obsolete attribute to annotate deprecated types in LSP Types: Do not use Obsolete attribute to annotate deprecated types in LSP May 6, 2024
@TheAngryByrd TheAngryByrd requested a review from baronfel May 6, 2024 19:55
Copy link
Contributor

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, in hindsight this was not a great idea. If these were classes then we could use alternate constructors and things like that, but with records and every property needing used it just leads to noise.

@baronfel baronfel merged commit 33e881d into ionide:main May 7, 2024
2 of 3 checks passed
@razzmatazz razzmatazz deleted the remove-obsolete-attributes branch May 9, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants