Remove decorations when removing a file from a project #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this @MangelMaxime - I've released an FSAC with your removal fix and will include this whole package in tonight's Ionide release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview:
remove_decoration_when_removing_file.mp4
This PR remove the decorations added by the
PipelineHintsandLineLenswhen removing a file.With this PR and when ionide/FsAutoComplete#1005 will be merged we should have everything cleaned when removing a file.
ionide/FsAutoComplete#1005 is needed to:
With the FSAC PR, if you re-open the file then it still consider that it can access others files content which is wrong :)