Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental setting to leverage FSAC path as an extra --compilertool flag #1959

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

smoothdeveloper
Copy link

@smoothdeveloper smoothdeveloper commented Nov 11, 2023

add experimental option to conveniently add --compilertool:/path/to/fsac to the FSI session.

related:

WHAT

🤖 Generated by Copilot at 0cfe72a

This pull request refactors the FSAC dll resolution and adds an experimental option to use the FSAC extensions in F# interactive. It also improves the logic for finding and passing the F# interactive parameters and fixes some terminal issues on windows. The main files affected are src/Core/LanguageService.fs, release/package.json, and src/Components/Fsi.fs.

🤖 Generated by Copilot at 0cfe72a

FSAC path tweaks
enhance F# interactive
autumn of refactor

🛠️🚀♻️

WHY

FSAC is bound to ship great FSI extensions, let's make it convenient for users to add those to the FSI session.

HOW

🤖 Generated by Copilot at 0cfe72a

  • Add a new configuration option FSharp.fsiUsesFSACDirectoryForCompilerTool to enable loading FSAC extensions in F# interactive (link)
  • Modify fsiBinaryAndParameters function to use the new option and pass the --compilertool argument to F# interactive with the FSAC path (link)
  • Add a new SdkResolution module to LanguageService.fs to handle locating the FSAC dll and the target framework for the current SDK (link)
  • Simplify getOptions function in LanguageService.fs by using the SdkResolution module and removing duplicated logic (link, link)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant