Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest FCS #192

Merged
merged 8 commits into from
Jun 26, 2023
Merged

Latest FCS #192

merged 8 commits into from
Jun 26, 2023

Conversation

dawedawe
Copy link

@dawedawe dawedawe commented Jun 23, 2023

WHAT

🤖 Generated by Copilot at 2d50bd2

Updated the project to use the latest FCS API and dotnet7 feed, and fixed the tests accordingly. This improves the compatibility and performance of the library with the latest F# compiler service and .NET SDK.

🤖 Generated by Copilot at 2d50bd2

Sing, O Muse, of the valiant deeds of the F# heroes
Who, with skill and wisdom, updated their code to the latest FCS
And made their paket.dependencies shine like the stars of heaven
And their FCS module and Tests.fs swift and smooth as the wind

🆙🛠️🧪

WHY

This is to go along with ionide/FsAutoComplete#1122 and help the CI over there.
Is there a mechanism to build a nightly for FSAC with these changes?

HOW

🤖 Generated by Copilot at 2d50bd2

  • Update dependencies to use dotnet7 feed and latest FCS prerelease versions (link)
  • Use new constructors for FSharpReferencedProject to avoid deprecated methods (link, link, link)
  • Adjust tests to match the new FSharpReferencedProject.PEReference fields and properties (link)
  • Reformat paket.dependencies file by running paket install (link)

@dawedawe dawedawe changed the title Adjust to FSharp.Compiler.Service 43.7.400 prerelease Latest FCS Jun 23, 2023
@nojaf
Copy link
Contributor

nojaf commented Jun 26, 2023

@baronfel, @TheAngryByrd as this is a part of getting ionide/FsAutoComplete#1122 green. Would it make sense to do the git submodule thing in FSAC? And build that proj-info dep from source in the nightly branch?

@TheAngryByrd
Copy link
Member

@baronfel, @TheAngryByrd as this is a part of getting fsharp/FsAutoComplete#1122 green. Would it make sense to do the git submodule thing in FSAC? And build that proj-info dep from source in the nightly branch?

We could publish this as some type of beta on nuget unless you want to submodule FCS as well.

@TheAngryByrd TheAngryByrd changed the base branch from main to nightly June 26, 2023 23:30
@TheAngryByrd TheAngryByrd merged commit 0a5b45e into ionide:nightly Jun 26, 2023
@dawedawe dawedawe deleted the latest-fcs branch June 27, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants