This repository has been archived by the owner on Dec 2, 2023. It is now read-only.
Update udp #279
Merged
Update udp #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update module rs/zerolog to v1.19.0
Generated by renovateBot
Code from dtls
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
==========================================
- Coverage 25.67% 24.14% -1.54%
==========================================
Files 38 38
Lines 2968 2978 +10
==========================================
- Hits 762 719 -43
- Misses 2074 2123 +49
- Partials 132 136 +4
Continue to review full report at Codecov.
|
jbrady42
reviewed
Jun 4, 2020
| L_CLOSE: | ||
| for { | ||
| select { | ||
| case c := <-l.acceptCh: |
There was a problem hiding this comment.
What is the point of the select and break to label here instead of just waiting on the channel read?
tarrencev
reviewed
Jun 4, 2020
| @@ -356,8 +356,8 @@ github.com/xtaci/lossyconn v0.0.0-20200209145036-adba10fffc37/go.mod h1:HpMP7DB2 | |||
| github.com/zenazn/goji v0.9.0/go.mod h1:7S9M489iMyHBNxwZnk9/EHS098H4/F6TATF2mIxtB1Q= | |||
| go.etcd.io/bbolt v1.3.2 h1:Z/90sZLPOeCy2PwprqkFa25PdkusRzaj9P8zm/KNyvk= | |||
| go.etcd.io/bbolt v1.3.2/go.mod h1:IbVyRI1SCnLcuJnV2u8VeU0CEYM7e686BmAb1XKL+uU= | |||
| go.etcd.io/etcd v3.3.4+incompatible h1:XtjpOPpV0r9nDCHbfY+DbscPUj2dFSg3yu2HDHWkj/M= | |||
There was a problem hiding this comment.
I downgraded to avoid this issue: etcd-io/etcd#11931
I think if we can upgrade to v3.4 then it is solved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update udp
code form dtls
concurrently read and accept UDP packet
some other update commits