Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add hostname to server and vcpu_server and servers #697

Merged
merged 8 commits into from
Oct 28, 2024
Merged

feature: add hostname to server and vcpu_server and servers #697

merged 8 commits into from
Oct 28, 2024

Conversation

cristiGuranIonos
Copy link
Collaborator

What does this fix or implement?

Checklist

  • PR name added as appropriate (e.g. feat:/fix:/doc:/test:/refactor:)
  • Tests added or updated
  • Documentation updated
  • Changelog updated and version incremented (label: upcoming release)
  • Github Issue linked if any
  • Jira task updated

@cristiGuranIonos cristiGuranIonos changed the title feature: add hostname to server and vcpu_server feature: add hostname to server and vcpu_server and servers ds Oct 25, 2024
@cristiGuranIonos cristiGuranIonos changed the title feature: add hostname to server and vcpu_server and servers ds feature: add hostname to server and vcpu_server and servers Oct 25, 2024
adeatcu-ionos
adeatcu-ionos requested changes Oct 28, 2024
View reviewed changes
docs/data-sources/server.md Outdated Show resolved Hide resolved
docs/resources/volume.md Show resolved Hide resolved
ionoscloud/data_source_servers.go Outdated Show resolved Hide resolved
ionoscloud/resource_server.go Show resolved Hide resolved
ionoscloud/resource_server.go Outdated Show resolved Hide resolved
ionoscloud/resource_server_test.go Show resolved Hide resolved
ionoscloud/resource_vcpu_server.go Show resolved Hide resolved
ionoscloud/resource_vcpu_server_test.go Show resolved Hide resolved
cristiGuranIonos and others added 3 commits October 28, 2024 14:31
@cristiGuranIonos @adeatcu-ionos
Update docs/data-sources/server.md
cc15f9f 
Co-authored-by: Deatcu Andrei-Cristian <andrei-cristian.deatcu@ionos.com>
@cristiGuranIonos
fix: code review
fa9b330
@cristiGuranIonos
Merge remote-tracking branch 'origin/feat/add_hostname' into feat/add…
fa972db 
…_hostname
adeatcu-ionos
adeatcu-ionos previously approved these changes Oct 28, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
21.9% Duplication on New Code

See analysis details on SonarCloud

@cristiGuranIonos cristiGuranIonos merged commit bac7fc9 into master Oct 28, 2024
7 checks passed
@cristiGuranIonos cristiGuranIonos deleted the feat/add_hostname branch October 28, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adeatcu-ionos adeatcu-ionos adeatcu-ionos left review comments

@rmocanu-ionos rmocanu-ionos Awaiting requested review from rmocanu-ionos rmocanu-ionos was automatically assigned from ionos-cloud/sdks-development

@mimihalescu mimihalescu Awaiting requested review from mimihalescu mimihalescu was automatically assigned from ionos-cloud/sdks-development

@avirtopeanu-ionos avirtopeanu-ionos Awaiting requested review from avirtopeanu-ionos avirtopeanu-ionos was automatically assigned from ionos-cloud/sdks-development

@glimberea glimberea Awaiting requested review from glimberea glimberea was automatically assigned from ionos-cloud/sdks-development

@cbeti-ionos cbeti-ionos Awaiting requested review from cbeti-ionos cbeti-ionos was automatically assigned from ionos-cloud/sdks-development

@digna-ionos digna-ionos Awaiting requested review from digna-ionos digna-ionos was automatically assigned from ionos-cloud/sdks-development

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cristiGuranIonos @adeatcu-ionos