refactor: Use bundle instead of SDK for Cert Manager #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adeatcu-ionos
requested review from
a team,
rmocanu-ionos,
mimihalescu,
cristiGuranIonos,
avirtopeanu-ionos,
glimberea,
cbeti-ionos and
cciopa-ionos
and removed request for
a team
adeatcu-ionos
force-pushed
the
use-bundle-instead-of-sdk-for-cert-manager
branch
from
ee3de0a to
d462238
Compare
| @@ -8,7 +8,7 @@ import ( | |||
| "github.com/hashicorp/terraform-plugin-sdk/v2/diag" | |||
| "github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema" | |||
| "github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation" | |||
| certSDK "github.com/ionos-cloud/sdk-go-cert-manager" | |||
| certSDK "github.com/ionos-cloud/sdk-go-bundle/products/cert/v2" | |||
There was a problem hiding this comment.
certSDK should be renamed to certsdk. Camelcase is not allowed for package names.
There was a problem hiding this comment.
@cristiGuranIonos done in dd8991f
adeatcu-ionos
force-pushed
the
use-bundle-instead-of-sdk-for-cert-manager
branch
from
dd8991f to
05a059c
Compare
|
rmocanu-ionos
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this fix or implement?
Checklist
feat:/fix:/doc:/test:/refactor:)