For mozilla-mobile#11545 - Replace clearColorFilter with setColorFilt…

…er for security icon

Clear color filter doesn't work on Api 21, 22
Even if we invalidate the view after clearColorFilter the filter is not removed, so to fix the bug
we need to use setColorFilter with color Color.Transparent

components/browser/toolbar/src/main/java/mozilla/components/browser/toolbar/display/DisplayToolbar.kt

@@ -5,7 +5,6 @@
 package mozilla.components.browser.toolbar.display
 
 import android.content.Context
-import android.graphics.Color
 import android.graphics.Typeface
 import android.graphics.drawable.Drawable
 import android.util.TypedValue
@@ -500,12 +499,7 @@ class DisplayToolbar internal constructor(
             Toolbar.SiteSecurity.INSECURE -> colors.securityIconInsecure
             Toolbar.SiteSecurity.SECURE -> colors.securityIconSecure
         }
-        if (color == Color.TRANSPARENT) {
-            views.securityIndicator.clearColorFilter()
-        } else {
-            views.securityIndicator.setColorFilter(color)
-        }
-
+        views.securityIndicator.setColorFilter(color)
         views.securityIndicator.siteSecurity = siteSecurity
     }
 

components/browser/toolbar/src/test/java/mozilla/components/browser/toolbar/display/DisplayToolbarTest.kt

@@ -648,13 +648,6 @@ class DisplayToolbarTest {
 
         assertNull(displayToolbar.views.securityIndicator.colorFilter)
 
-        displayToolbar.colors = displayToolbar.colors.copy(
-            securityIconSecure = Color.TRANSPARENT,
-            securityIconInsecure = Color.TRANSPARENT
-        )
-
-        assertNull(displayToolbar.views.securityIndicator.colorFilter)
-
         displayToolbar.colors = displayToolbar.colors.copy(
             securityIconSecure = Color.BLUE,
             securityIconInsecure = Color.BLUE

docs/changelog.md

@@ -11,6 +11,9 @@ permalink: /changelog/
 * [Gecko](https://github.com/mozilla-mobile/android-components/blob/main/buildSrc/src/main/java/Gecko.kt)
 * [Configuration](https://github.com/mozilla-mobile/android-components/blob/main/.config.yml)
 
+* **browser-toolbar**
+  * 🚒 Bug fixed [issue #11545](https://github.com/mozilla-mobile/android-components/issues/11545) - `clearColorFilter` doesn't work on Api 21, 22, so the default white filter remains set.Use `setColorFilter` method for all scenarios
+
 * **lib/publicsuffixlist**
   * ⚠️ **This is a breaking change**: Removed `String.urlToTrimmedHost` extension method.