Added comment dependency injection to ICommentPolicy, reformat of com…

…ment controller
iooe · Mar 30, 2019 · 41853fb · 41853fb
1 parent 974eae5
commit 41853fb
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 13 deletions.
diff --git a/src/Contracts/ICommentPolicy.php b/src/Contracts/ICommentPolicy.php
@@ -1,6 +1,7 @@
 <?php
 
 namespace tizis\laraComments\Contracts;
+use tizis\laraComments\Entity\Comment;
 
 /**
  * Comment auth policy
@@ -10,11 +11,11 @@
  */
 interface ICommentPolicy
 {
-    public function edit($user, $comment);
+    public function edit($user, Comment $comment);
 
-    public function delete($user, $comment);
+    public function delete($user, Comment $comment);
 
-    public function reply($user, $comment);
+    public function reply($user, Comment $comment);
 
-    public function vote($user, $comment);
+    public function vote($user, Comment $comment);
 }
diff --git a/src/Http/Controllers/CommentsController.php b/src/Http/Controllers/CommentsController.php
@@ -4,7 +4,6 @@
 
 use Auth;
 use Illuminate\Foundation\Auth\Access\AuthorizesRequests;
-use Illuminate\Foundation\Validation\ValidatesRequests;
 use Illuminate\Http\Request;
 use Illuminate\Routing\Controller;
 use tizis\laraComments\Entity\Comment;
@@ -19,7 +18,7 @@
 
 class CommentsController extends Controller
 {
-    use ValidatesRequests, AuthorizesRequests;
+    use AuthorizesRequests;
 
     protected $commentService;
     protected $voteService;

diff --git a/src/Policies/CommentPolicy.php b/src/Policies/CommentPolicy.php
@@ -9,20 +9,20 @@ class CommentPolicy implements ICommentPolicy
 {
     /**
      * @param $user
-     * @param $comment
+     * @param Comment $comment
      * @return bool
      */
-    public function delete($user, $comment): bool
+    public function delete($user, Comment $comment): bool
     {
         return $user->id === $comment->commenter_id;
     }
 
     /**
      * @param $user
-     * @param $comment
+     * @param Comment $comment
      * @return bool
      */
-    public function edit($user, $comment): bool
+    public function edit($user, Comment $comment): bool
     {
         return $user->id === $comment->commenter_id;
     }
@@ -32,17 +32,17 @@ public function edit($user, $comment): bool
      * @param Comment $comment
      * @return bool
      */
-    public function reply($user, $comment): bool
+    public function reply($user, Comment $comment): bool
     {
         return true;
     }
 
     /**
      * @param $user
-     * @param $comment
+     * @param Comment $comment
      * @return bool
      */
-    public function vote($user, $comment): bool
+    public function vote($user, Comment $comment): bool
     {
         return $user->id !== $comment->commenter_id;
     }