This repository has been archived by the owner on Jan 27, 2021. It is now read-only.
Fixed issue when root subspace was composed with redux dev tools #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ux-saga and redux-observable
jpeyper
approved these changes
Sep 4, 2017
| @@ -16,9 +17,9 @@ const verifyState = (state) => { | |||
| return state | |||
| } | |||
|
|
|||
| const subspaceEnhancer = (mapState, namespace) => applySubspaceMiddleware((store) => ({ | |||
| const subspaceEnhancer = (mapState, namespace) => applySubspaceMiddleware(applyToChildren((store) => ({ | |||
There was a problem hiding this comment.
I'm still not clear on why this was required.
There was a problem hiding this comment.
Again, I don't know why it occurs when the dev-tools-extension is used, but the store.rootStore.getState() call on the next line ends up back in this function and infinitely loops calling getState on the root store. This just enforces the a root subspace will never use this function.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a pretty severe bug with the current alpha version when composing
applyMiddlewarewith the redux-devtools-extension that causes an infinite loop whengetStatewas called.I'm not sure why it only occured when using the extension, and not when using the dev tools directly, like in the real world example, but this change works for both, and when not using dev tools at all.
The change looks more complicated than it really is. Basically, if the subspace is the root store, don't map the state, or namespace the actions (it was defaulting to
subspace((state) => state, undefined)anyway).To achieve this I also had to fix a minor issue when subspaces not created from
applyMiddlewarethought they were the root store ifapplyMiddlewarewas not used at all. Most of the noise in this review is caused by fixing that, rather than the actual bug.