Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused deps #194

Merged
merged 5 commits into from
Jul 5, 2021
Merged

remove unused deps #194

merged 5 commits into from
Jul 5, 2021

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Jul 2, 2021

@callumrollo also using this one to test the CI failure you are experimenting in #192.

@ocefpaf ocefpaf force-pushed the test_CIs branch 3 times, most recently from 808825c to fd33337 Compare July 2, 2021 19:18
@@ -17,7 +17,7 @@ jobs:
- uses: actions/checkout@v2

- name: Setup Conda
uses: s-weigand/setup-conda@v1
uses: s-weigand/setup-conda@v1.0.5
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@callumrollo looks like it is the latest release of this GHA (1.0,6). Pinning to the previous one fixes it. I'll push that change to your branch.

@callumrollo
Copy link
Contributor

@ocefpaf can we merge this? Then I can update the two other PRs

Co-authored-by: Sebastian Weigand <s.weigand.phy@gmail.com>
@ocefpaf
Copy link
Member Author

ocefpaf commented Jul 5, 2021

@ocefpaf can we merge this? Then I can update the two other PRs

Not right now. Let's wait for an official release of the GHA. Meanwhile I'm OK downgrading to the previous version.

@s-weigand
Copy link
Contributor

Give me 5min and you will have the release 😄
Thanks again for testing!

@ocefpaf
Copy link
Member Author

ocefpaf commented Jul 5, 2021

Thanks so much for the quick fix @s-weigand!

@ocefpaf ocefpaf merged commit 8b17fb9 into ioos:main Jul 5, 2021
@ocefpaf ocefpaf deleted the test_CIs branch July 5, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants