-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove stream config #100
Remove stream config #100
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
93e627e
to
c0c1bdd
Compare
@kthyng sorry to ping you here but who would be the best person to review this one? |
@ocefpaf No problem! We're discussing internally about getting some people involved. |
Hi @ocefpaf - thanks for taking a stab here. @melaniefeen and I took a look at it together. These changes to documentation look good. We did notice that
But |
docs/source/usage.rst
Outdated
} | ||
c = StreamConfig(config) | ||
|
||
|
||
ContextConfig | ||
~~~~~~~~~~~~~ | ||
A ``ContextConfig`` object defines multiple ``StreamConfig`` objects as well as optional `region` and `window` objects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should StreamConfig
be replaced w/ something else here? What's the new object called?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ContextConfig can take any ConfigType if I understood the code correctly. I changed to that instead of StreamConfig.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea I see that now, ConfigType
object is what we're passing when initializing ContextConfig
class.
Quoting Kyle from #99 (comment):
My guess is that this is already documented, right? So it is a matter of just removing StreamConfig. I'll remove it from the places you pointed out. |
Looks good to me! @ocefpaf |
Start to address #99