Fixed spike test masked array issue #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed issue in spike_test where the ref array was not getting initialized as a masked array. This was causing some values that should result in a masked restult to use the underlying value stored in the masked array to be using in the calculation resulting in incorrect results. For example, with the following input: [101, 102, --, 104, 105] The resulting output should be: [2, 9, 9, 9, 2] However, with the ref array initialized as a non masked array the following is the result: [2, 1, 9, 9, 2] The affected tests were also updated to reflect the correct behavior.
przybytek
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue in spike_test where the ref array was not getting initialized as a masked array. This was causing some values that should result in a masked restult to use the underlying value stored in the masked array to be using in the calculation resulting in incorrect results.
For example, with the following input:
[101, 102, --, 104, 105]
The resulting output should be:
[2, 9, 9, 9, 2]
However, with the ref array initialized as a non masked array the following is the result:
[2, 1, 9, 9, 2]
The affected tests were also updated to reflect the correct behavior.