Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defers loading @iopipe/core until dependency cycles resolve #66

Merged
merged 1 commit into from
Jul 12, 2019
Merged

Defers loading @iopipe/core until dependency cycles resolve #66

merged 1 commit into from
Jul 12, 2019

Conversation

mrickard
Copy link
Contributor

Waits to require core's util so that dependency loading can be completed, and makes that conditional to avoid unnecessary loading.
Moves @iopipe/core to devDependencies
Closes #45
Closes #64

@mrickard
Moves @iopipe/core to devDependencies
0c0304e 
Waits to require core's util so that dependency loading can be completed, and makes that conditional to avoid unnecessary loading.
Closes iopipe#45
Closes iopipe#64
kolanos
kolanos approved these changes Jul 11, 2019
View reviewed changes
src/index.js Show resolved Hide resolved
@mrickard mrickard merged commit 3a63dbf into iopipe:master Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolanos kolanos kolanos approved these changes

@ewindisch ewindisch Awaiting requested review from ewindisch

@austinhuminski austinhuminski Awaiting requested review from austinhuminski

@javonharper javonharper Awaiting requested review from javonharper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enabling profiling via env variable in Serverless Framework not working Errors silently on local invoke
2 participants
@mrickard @kolanos