Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boto3 requests not being auto traced in 3.7 #319

Closed
austinhuminski opened this issue May 17, 2019 · 1 comment · Fixed by #321
Closed

boto3 requests not being auto traced in 3.7 #319

austinhuminski opened this issue May 17, 2019 · 1 comment · Fixed by #321
Labels
bug

Comments

@austinhuminski
Copy link

Description

When using python3.7 runtime, requests made via boto3 are not being auto traced. When changing the runtime to 3.6 it started tracing

Steps to reproduce the issue:

client = boto3.client('s3')
client.list_buckets()

Describe the results you received:
Nothing showing up in the tracing tab

Describe the results you expected:
The s3 call to list all buckets be auto traced
@kolanos
Copy link
Contributor

kolanos commented Jun 6, 2019

It looks like botocore is no longer using requests and implements it's own HTTP wrapper now. Will need to reimplement/revise the monkey patching for newer versions.

kolanos added a commit to kolanos/iopipe-python that referenced this issue Jun 6, 2019
@kolanos
Add monkey patching for botocore.httpsession
8490104 
Closes iopipe#319
@kolanos kolanos mentioned this issue Jun 6, 2019
Merged
kolanos added a commit that referenced this issue Jun 6, 2019
@kolanos
Add monkey patching for botocore.httpsession (#321)
43828d5 
* Add monkey patching for botocore.httpsession

Closes #319

* Rmove AWSResponse, don't need it

* Add monkey patching test

* Add mock filter to test

* Make monkey patching python2.7 compatible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add monkey patching for botocore.httpsession kolanos/iopipe-python
2 participants
@kolanos @austinhuminski