Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow trace marker to be use as decorator #325

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Allow trace marker to be use as decorator #325

merged 1 commit into from
Jun 11, 2019

Conversation

kolanos
Copy link
Contributor

@kolanos kolanos commented Jun 7, 2019

Closes #297

@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #325 into master will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #325     +/-   ##
=========================================
+ Coverage   83.21%   83.42%   +0.2%     
=========================================
  Files          36       36             
  Lines        1317     1333     +16     
=========================================
+ Hits         1096     1112     +16     
  Misses        221      221
Impacted Files Coverage Δ
iopipe/contrib/trace/marker.py 98.03% <100%> (+0.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90c1898...58d3134. Read the comment docs.

@kolanos kolanos self-assigned this Jun 7, 2019
mrickard
mrickard approved these changes Jun 11, 2019
View reviewed changes
Copy link

@mrickard mrickard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kolanos kolanos merged commit cadd2d5 into iopipe:master Jun 11, 2019
@kolanos kolanos deleted the issue/297 branch June 11, 2019 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrickard mrickard mrickard approved these changes

@austinhuminski austinhuminski Awaiting requested review from austinhuminski

@javonharper javonharper Awaiting requested review from javonharper

Assignees

@kolanos kolanos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Decorator for adding Trace names
2 participants
@kolanos @mrickard