Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ALB Event Info #330

Merged
merged 2 commits into from
Jun 12, 2019
Merged

Add ALB Event Info #330

merged 2 commits into from
Jun 12, 2019

Conversation

kolanos
Copy link
Contributor

@kolanos kolanos commented Jun 12, 2019 •
edited
Loading

Closes #314

@kolanos kolanos self-assigned this Jun 12, 2019
@codecov
Copy link

codecov bot commented Jun 12, 2019 •
edited
Loading

Codecov Report

Merging #330 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
+ Coverage   83.51%   83.56%   +0.04%     
==========================================
  Files          36       36              
  Lines        1347     1351       +4     
==========================================
+ Hits         1125     1129       +4     
  Misses        222      222
Impacted Files Coverage Δ
iopipe/contrib/eventinfo/event_types.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d989c2...51e5d44. Read the comment docs.

mrickard
mrickard approved these changes Jun 12, 2019
View reviewed changes
Copy link

@mrickard mrickard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kolanos kolanos merged commit 716a9fb into iopipe:master Jun 12, 2019
@kolanos kolanos deleted the issue/314 branch June 12, 2019 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrickard mrickard mrickard approved these changes

@austinhuminski austinhuminski Awaiting requested review from austinhuminski

Assignees

@kolanos kolanos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ALB event-info
2 participants
@kolanos @mrickard