Marker Check for Auto HTTP Monkey PAtching #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #333 +/- ##
==========================================
- Coverage 83.66% 83.57% -0.09%
==========================================
Files 36 36
Lines 1359 1364 +5
==========================================
+ Hits 1137 1140 +3
- Misses 222 224 +2
Continue to review full report at Codecov.
|
The monkey patching assumes a marker is present but this may not always be the case. For example, if the profiler plugin is loaded after the trace plugin, then the profiler won't be provided an active marker. This removes marker removal and makes the monkey patching defensive about the presence of markers.
kolanos
force-pushed
the
trace-profiler-combo
branch
from
298f370 to
3b45450
Compare
austinhuminski
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The monkey patching assumes a marker is present but this may not always
be the case. For example, if the profiler plugin is loaded after the
trace plugin, then the profiler won't be provided an active marker. This
removes marker removal and makes the monkey patching defensive about the
presence of markers.