Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosmiconfig plugins that are not strings do not work #86

Closed
coreylight opened this issue Aug 8, 2018 · 0 comments · Fixed by #87
Closed

Cosmiconfig plugins that are not strings do not work #86

coreylight opened this issue Aug 8, 2018 · 0 comments · Fixed by #87
Assignees
@coreylight
Labels
bug

Comments

@coreylight
Copy link
Contributor

If the plugin is passed as an array to utilize inline configuration, the plugin fails with an error like this:
Module not found: Error: Can't resolve '@iopipe/logger,[object Object]'
@coreylight coreylight added the bug label Aug 8, 2018
@coreylight coreylight self-assigned this Aug 8, 2018
coreylight added a commit to coreylight/serverless-plugin-iopipe that referenced this issue Aug 8, 2018
@coreylight
fix(packge.json config): fix package.json configuration method for pl…
f3a0275 
…ugins with options

fix iopipe#86
@coreylight coreylight mentioned this issue Aug 8, 2018
Merged
coreylight added a commit that referenced this issue Aug 9, 2018
@coreylight
fix(packge.json config): configuration method for plugins with options (
ee4fa1a 
#87)

fix #86
coreylight added a commit to coreylight/serverless-plugin-iopipe that referenced this issue Aug 20, 2018
@coreylight
fix(individual function deploy): use serverless function deploy hook
36a18a7 
fix iopipe#86
coreylight added a commit to coreylight/serverless-plugin-iopipe that referenced this issue Aug 20, 2018
@coreylight
fix(individual function deploy): use serverless function deploy hook
f607ff1 
fix iopipe#86
@coreylight coreylight mentioned this issue Aug 20, 2018
Merged
coreylight added a commit that referenced this issue Aug 22, 2018
@coreylight
fix(individual function deploy): use serverless function deploy hook (#…
46d6f31 
…89)

fix #86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coreylight coreylight

Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@coreylight