-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sanitize file names that include device_id for iPhone xs series #360
Conversation
Hah I didn't see this and fixed the same issue! https://github.com/collindutter/ios-deploy/commit/efef06839812f20679c1c69876c6a87fa24efc39 |
Can we merge this please? 😄 It looks like a small fix and will let us use this lib for new iPhones. |
I know this it the epitome of a first world problem but can we get at least a vague timeline on how long it will take to merge this? I ask because if we are talking more than another week for a merge/release I need to start the process of building this myself so that our developers can deploy to the new phones. |
@joshstrange it's definitely not ideal, but you should be able to install ios-deploy from one of our forked repos where the fix is. |
if you are using homebrew then you can run
|
Nice! I would add that the latest libimobiledevice version requires a higher version of usbmuxd, so after you make that edit to the ios-deploy brew file, run these terminal commands:
However, I'm still getting the error: |
Ok the |
pls merge! |
I just requested testing & review on Slack since I do not use ios-deploy so much myself. I recommend you guys ping us via dev@cordova.apache.org or Slack in case of this kind of delay. |
Hey @brodybits, what is the Slack URL? Additionally, when would we sensibly expect this to be merged? If it's not far off I'll just wait for an update, otherwise I might go with @timtraversy's approach. Cheers! |
https://cordova.slack.com/archives/CCH3ESRB8/p1539635196000100
I cannot say anything myself. I said before that I do not really use this tool myself. @shazron? I think the ultimate solution would be to use https://github.com/appcelerator/node-ios-device, which has permissive Apache 2.0 license, as discussed in apache/cordova-ios#429. The recommended way to get our attention is via dev@cordova.apache.org and http://cordova.slack.com. |
Hi @beardo01 @timtraversy @HelveticaScenario @brodybits I just pinged shazron. |
Looking at this right now. |
I don't have an XS to test with so I can't vouch for that test, but compiling the changes and deploying an app still works fine. |
Thanks @shazron! |
@shazron I wonder how to use brew upgrade to this latest one? |
Seems like npm is able to install version 1.9.4 which has this PR in it.
and then
I got it working |
the device_id of the new iPhone XS series has changed to a 25 digit hexadecimal string with a '-' character for the 9th character. '-' characters aren't allowed to be file names in python so when the autogenerated python files were imported they would fail with a syntax error due to the new device id being in the name. this sanitized the file names to replace the '-' character with a '_'