Disable GCC-style coverage instrumentation

[jakubvano]

Our build of an app with IDZSwiftCommonCrypto integrated via carthage was rejected by appstore becasue of

Invalid Bundle - Do not submit apps with GCC-style coverage instrumentation enabled. Specifically, the following Xcode build settings should be disabled: Instrument Program Flow Generate Test Coverage Files

Disabling GCC_GENERATE_TEST_COVERAGE_FILES and GCC_INSTRUMENT_PROGRAM_FLOW_ARCS fixes that.

Are these options somehow essential for IDZSwiftCommonCrypto or were they enabled due to oversight?

[iosdevzone]

Hi Jakub,
First of all, apologies for the inconvenience, the settings you mention should not have made it into a release build, they are used by the coveralls service to monitor test coverage.
I will look into it and either merge your pull request as is or modify it appropriately.
Thank you for reporting this issue.
idz
P.S. If would like to let me know the name of your app I will add a section to the README "Apps Using IDZSwiftCommonCrypto" and list it there.

[jakubvano]

Hi, thanks for the quick reply. It was just a minor inconvenience, and I'm glad I could contribute. As for adding our app to the list - it won't be released for a couple of months, and I would have to consult my superiors first. Anyway, will let you know.

[iosdevzone]

I've just merged PR #35 and pushed out release 0.7.4. This release includes a slightly modified version of your proposed fix. In #35 coverage is turned off in Release builds but remains on in Debug builds. As long as you don't link with a debug build this problem should not occur again.
Thanks for your patience and sorry it took so long to get it merged into the master branch!