refactor(modules): extract bichat
from core
into its own module
#107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moments that I am still unsure of are:
bichat.templ
still referencing core template layoutchatfuncs
services were moved tobichat
(I couldn't find a module that referenced it, so I moved it just in case because it seemed more relevant tobichat
than tocore
)modules/bichat/module.go
theRegister
function. Please verify if I correctly initialized the necessary services/controllersdialogue_events.go
still referencescore
domain user aggregate.Overall, I assumed it is okay that modules can reference
core
when necessary (such as user aggregate) but not vice versa to prevent cyclic dependencies.