Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(modules): extract bichat from core into its own module #107

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

thelissimus-work
Copy link
Contributor

Moments that I am still unsure of are:

  • bichat.templ still referencing core template layout
  • chatfuncs services were moved to bichat (I couldn't find a module that referenced it, so I moved it just in case because it seemed more relevant to bichat than to core)
  • modules/bichat/module.go the Register function. Please verify if I correctly initialized the necessary services/controllers
  • dialogue_events.go still references core domain user aggregate.

Overall, I assumed it is okay that modules can reference core when necessary (such as user aggregate) but not vice versa to prevent cyclic dependencies.

@diyor28
Copy link
Contributor

diyor28 commented Feb 5, 2025

Moments that I am still unsure of are:

  • bichat.templ still referencing core template layout
  • chatfuncs services were moved to bichat (I couldn't find a module that referenced it, so I moved it just in case because it seemed more relevant to bichat than to core)
  • modules/bichat/module.go the Register function. Please verify if I correctly initialized the necessary services/controllers
  • dialogue_events.go still references core domain user aggregate.

Overall, I assumed it is okay that modules can reference core when necessary (such as user aggregate) but not vice versa to prevent cyclic dependencies.

You are absolutely correct in your assumptions. Referencing down the chain is okay and inevitable. Vise versa not acceptible

@diyor28 diyor28 merged commit db9e565 into main Feb 6, 2025
1 check failed
@diyor28 diyor28 deleted the sdk-104 branch February 6, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants