Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infinite scroll for users table #165

Merged
merged 7 commits into from
Mar 2, 2025
Merged

infinite scroll for users table #165

merged 7 commits into from
Mar 2, 2025

Conversation

thelissimus-work
Copy link
Contributor

Closes: #159 and #161

  • Users are loaded dynamically as the user scrolls down.
  • No noticeable lag or delay in loading new users.
  • API calls are optimized and do not cause excessive load on the server.
  • Works consistently across different screen sizes and devices.
  • If the users table supports sorting or filtering, ensure that infinite scroll works correctly with these features.
  • Implement search by name for users.

Other changes:

  • Pagination page default value is handled and page indexing is not starts with 1 and not 0.
  • Refactored Cypress test utilities.

@thelissimus-work thelissimus-work requested a review from diyor28 March 1, 2025 19:42
Copy link

cypress bot commented Mar 1, 2025

Default Project    Run #64

Run Properties:  status check passed Passed #64  •  git commit c91658c5b5: add: user search by name
Project Default Project
Branch Review sdk-159
Run status status check passed Passed #64
Run duration 00m 13s
Commit git commit c91658c5b5: add: user search by name
Committer ali
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 2
View all changes introduced in this branch ↗︎

@diyor28 diyor28 merged commit db84b7d into staging Mar 2, 2025
2 checks passed
@diyor28 diyor28 deleted the sdk-159 branch March 2, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants