Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Easier output creation with byte cost as amount #1324

Merged
merged 4 commits into from
Apr 5, 2022
Merged

Easier output creation with byte cost as amount #1324

merged 4 commits into from
Apr 5, 2022

Conversation

thibault-martinez
Copy link
Member

@thibault-martinez thibault-martinez commented Apr 4, 2022 •
edited
Loading

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes
  • I have updated the CHANGELOG.md, if my changes are significant enough

@thibault-martinez thibault-martinez added wg-message Working Group - Message c-enhancement Category - Enhancement e-medium Experience - Medium p-medium Priority - Medium n-shimmer Network - Shimmer labels Apr 4, 2022
@thibault-martinez thibault-martinez added this to the v1.0 milestone Apr 4, 2022
@thibault-martinez thibault-martinez linked an issue Apr 4, 2022 that may be closed by this pull request
Easier output creation with minimum storage deposit #1268
Closed
pvdrz
pvdrz suggested changes Apr 4, 2022
View reviewed changes
bee-message/src/output/alias.rs Outdated Show resolved Hide resolved
@thibault-martinez thibault-martinez mentioned this pull request Apr 5, 2022
Open
@thibault-martinez thibault-martinez merged commit 0c37b57 into iotaledger:shimmer-develop Apr 5, 2022
@thibault-martinez thibault-martinez deleted the builder-storage-deposit branch April 5, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thoralf-M Thoralf-M Thoralf-M approved these changes

@pvdrz pvdrz pvdrz approved these changes

@samuel-rufi samuel-rufi samuel-rufi approved these changes

@bingyanglin bingyanglin Awaiting requested review from bingyanglin

Assignees
No one assigned
Labels
c-enhancement Category - Enhancement e-medium Experience - Medium n-shimmer Network - Shimmer p-medium Priority - Medium wg-message Working Group - Message
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

Easier output creation with minimum storage deposit
4 participants
@thibault-martinez @samuel-rufi @pvdrz @Thoralf-M