Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add milestone metadata #1328

Merged
merged 6 commits into from
Apr 5, 2022
Merged

Add milestone metadata #1328

merged 6 commits into from
Apr 5, 2022

Conversation

thibault-martinez
Copy link
Member

@thibault-martinez thibault-martinez commented Apr 5, 2022 •
edited
Loading

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes
  • I have updated the CHANGELOG.md, if my changes are significant enough

@thibault-martinez thibault-martinez added wg-message Working Group - Message c-feature Category - Feature e-medium Experience - Medium p-high Priority - High n-shimmer Network - Shimmer labels Apr 5, 2022
@thibault-martinez thibault-martinez added this to the v1.0 milestone Apr 5, 2022
bingyanglin
bingyanglin previously approved these changes Apr 5, 2022
View reviewed changes
@samuel-rufi samuel-rufi self-requested a review April 5, 2022 09:48
Alex6323
Alex6323 reviewed Apr 5, 2022
View reviewed changes
bee-message/src/error.rs Outdated Show resolved Hide resolved
bee-message/src/error.rs Outdated Show resolved Hide resolved
bee-message/src/payload/milestone/essence.rs Outdated Show resolved Hide resolved
bee-message/src/payload/milestone/mod.rs Outdated Show resolved Hide resolved
thibault-martinez and others added 4 commits April 5, 2022 12:02
@thibault-martinez @Alex6323
Update bee-message/src/payload/milestone/mod.rs
db9c2a9 
Co-authored-by: /alex/ <alexander.schmidt@iota.org>
@thibault-martinez @Alex6323
Update bee-message/src/error.rs
1d4d535 
Co-authored-by: /alex/ <alexander.schmidt@iota.org>
@thibault-martinez @Alex6323
Update bee-message/src/error.rs
f692dc3 
Co-authored-by: /alex/ <alexander.schmidt@iota.org>
@thibault-martinez @Alex6323
Update bee-message/src/payload/milestone/essence.rs
650d267 
Co-authored-by: /alex/ <alexander.schmidt@iota.org>
@thibault-martinez thibault-martinez merged commit 83a93be into iotaledger:shimmer-develop Apr 5, 2022
@thibault-martinez thibault-martinez deleted the add-milestone-metadata branch April 5, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuel-rufi samuel-rufi samuel-rufi approved these changes

@pvdrz pvdrz pvdrz approved these changes

@Alex6323 Alex6323 Alex6323 approved these changes

@bingyanglin bingyanglin bingyanglin approved these changes

Assignees
No one assigned
Labels
c-feature Category - Feature e-medium Experience - Medium n-shimmer Network - Shimmer p-high Priority - High wg-message Working Group - Message
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@thibault-martinez @samuel-rufi @pvdrz @Alex6323 @bingyanglin