Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify SDRUC syntactic validation rules #1329

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Simplify SDRUC syntactic validation rules #1329

merged 1 commit into from
Apr 5, 2022

Conversation

thibault-martinez
Copy link
Member

@thibault-martinez thibault-martinez commented Apr 5, 2022 •
edited
Loading

iotaledger/tips@8cfabe9

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes
  • I have updated the CHANGELOG.md, if my changes are significant enough

@thibault-martinez thibault-martinez added wg-message Working Group - Message c-enhancement Category - Enhancement e-medium Experience - Medium p-high Priority - High n-shimmer Network - Shimmer labels Apr 5, 2022
@thibault-martinez thibault-martinez added this to the v1.0 milestone Apr 5, 2022
@samuel-rufi samuel-rufi self-requested a review April 5, 2022 10:57
@thibault-martinez thibault-martinez merged commit 86a5eb9 into iotaledger:shimmer-develop Apr 5, 2022
@thibault-martinez thibault-martinez deleted the simplify-sdruc branch April 5, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grtlr grtlr grtlr approved these changes

@samuel-rufi samuel-rufi samuel-rufi approved these changes

@bingyanglin bingyanglin bingyanglin approved these changes

Assignees
No one assigned
Labels
c-enhancement Category - Enhancement e-medium Experience - Medium n-shimmer Network - Shimmer p-high Priority - High wg-message Working Group - Message
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@thibault-martinez @grtlr @samuel-rufi @bingyanglin