Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more NativeTokensBuilder helpers #1353

Merged
merged 3 commits into from
Apr 25, 2022
Merged

Add more NativeTokensBuilder helpers #1353

merged 3 commits into from
Apr 25, 2022

Conversation

thibault-martinez
Copy link
Member

@thibault-martinez thibault-martinez commented Apr 25, 2022 •
edited
Loading

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes
  • I have updated the CHANGELOG.md, if my changes are significant enough

@thibault-martinez thibault-martinez added wg-message Working Group - Message c-enhancement Category - Enhancement e-low Experience - Low p-high Priority - High n-shimmer Network - Shimmer labels Apr 25, 2022
@thibault-martinez thibault-martinez added this to the v1.0 milestone Apr 25, 2022
Thoralf-M
Thoralf-M previously approved these changes Apr 25, 2022
View reviewed changes
@samuel-rufi samuel-rufi self-requested a review April 25, 2022 08:11
samuel-rufi
samuel-rufi previously approved these changes Apr 25, 2022
View reviewed changes
Thoralf-M
Thoralf-M previously approved these changes Apr 25, 2022
View reviewed changes
pvdrz
pvdrz previously approved these changes Apr 25, 2022
View reviewed changes
@thibault-martinez thibault-martinez dismissed stale reviews from pvdrz and Thoralf-M via f4d3b3d April 25, 2022 08:38
@thibault-martinez thibault-martinez merged commit e812e15 into iotaledger:shimmer-develop Apr 25, 2022
@thibault-martinez thibault-martinez deleted the more-native-tokens-helper branch April 25, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvdrz pvdrz pvdrz approved these changes

@Alex6323 Alex6323 Alex6323 approved these changes

@Thoralf-M Thoralf-M Thoralf-M approved these changes

@samuel-rufi samuel-rufi samuel-rufi left review comments

@bingyanglin bingyanglin Awaiting requested review from bingyanglin

Assignees
No one assigned
Labels
c-enhancement Category - Enhancement e-low Experience - Low n-shimmer Network - Shimmer p-high Priority - High wg-message Working Group - Message
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@thibault-martinez @samuel-rufi @pvdrz @Alex6323 @Thoralf-M