Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convenience finish_output method #1355

Conversation

thibault-martinez
Copy link
Member

@thibault-martinez thibault-martinez commented Apr 25, 2022

It's very common to have to convert to the Output enum after having built an output.

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes
  • I have updated the CHANGELOG.md, if my changes are significant enough

@thibault-martinez thibault-martinez added wg-message Working Group - Message c-feature Category - Feature e-low Experience - Low p-low Priority - Low n-shimmer Network - Shimmer labels Apr 25, 2022
@samuel-rufi samuel-rufi self-requested a review April 25, 2022 13:48
@thibault-martinez thibault-martinez added this to the v1.0 milestone Apr 25, 2022
@thibault-martinez thibault-martinez merged commit 14e11ab into iotaledger:shimmer-develop Apr 25, 2022
@thibault-martinez thibault-martinez deleted the finish-output-method branch April 25, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-feature Category - Feature e-low Experience - Low n-shimmer Network - Shimmer p-low Priority - Low wg-message Working Group - Message
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants