Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version/health start checks from in-memory storage #1367

Conversation

thibault-martinez
Copy link
Member

@thibault-martinez thibault-martinez commented Apr 27, 2022

Unnecessary as there is no previous state so a mismatch can't happen.

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes
  • I have updated the CHANGELOG.md, if my changes are significant enough

@thibault-martinez thibault-martinez added wg-storage Working Group - Storage c-cleanup Category - Cleanup e-low Experience - Low p-low Priority - Low n-shimmer Network - Shimmer labels Apr 27, 2022
@samuel-rufi samuel-rufi self-requested a review April 27, 2022 11:04
@thibault-martinez thibault-martinez merged commit 34057ff into iotaledger:shimmer-develop Apr 27, 2022
@thibault-martinez thibault-martinez deleted the remove-storage-memory-checks branch April 27, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-cleanup Category - Cleanup e-low Experience - Low n-shimmer Network - Shimmer p-low Priority - Low wg-storage Working Group - Storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants