Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move milestone module #1371

Merged
merged 4 commits into from
Apr 28, 2022
Merged

Move milestone module #1371

merged 4 commits into from
Apr 28, 2022

Conversation

thibault-martinez
Copy link
Member

@thibault-martinez thibault-martinez commented Apr 27, 2022 •
edited
Loading

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes
  • I have updated the CHANGELOG.md, if my changes are significant enough

@thibault-martinez thibault-martinez marked this pull request as ready for review April 27, 2022 15:45
@thibault-martinez thibault-martinez added wg-message Working Group - Message c-cleanup Category - Cleanup e-low Experience - Low p-high Priority - High n-shimmer Network - Shimmer labels Apr 27, 2022
@thibault-martinez thibault-martinez merged commit 4d0d32f into iotaledger:shimmer-develop Apr 28, 2022
@thibault-martinez thibault-martinez deleted the move-milestone-module branch April 28, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grtlr grtlr grtlr approved these changes

@samuel-rufi samuel-rufi samuel-rufi approved these changes

@Alex6323 Alex6323 Awaiting requested review from Alex6323 Alex6323 is a code owner

@bingyanglin bingyanglin Awaiting requested review from bingyanglin

Assignees
No one assigned
Labels
c-cleanup Category - Cleanup e-low Experience - Low n-shimmer Network - Shimmer p-high Priority - High wg-message Working Group - Message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thibault-martinez @grtlr @samuel-rufi